Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M3 components should have rippleEnabled when clickable #85

Closed
zeoowl-dev opened this issue Nov 9, 2022 · 1 comment · Fixed by #96
Closed

M3 components should have rippleEnabled when clickable #85

zeoowl-dev opened this issue Nov 9, 2022 · 1 comment · Fixed by #96
Assignees
@teogor
Labels
components Marks an Issue/PR as linked to the ceres:components module @feature New feature or request m3 Marks an Issue/PR as linked to the ceres:m3 module @priority-medium

Comments

@zeoowl-dev
Copy link

For instance if a view is clickable it should have the ripple enabled. At the same time if we want to turn it off, respectively on we can still use the ripple_enabled attribute
@teogor teogor self-assigned this Nov 12, 2022
@teogor
Copy link
Owner

teogor commented Nov 12, 2022

That is indeed useful in some cases. Nice!

@teogor teogor added this to the 1.0.0-beta02 milestone Dec 1, 2022
@teogor teogor mentioned this issue Dec 1, 2022
Merged
3 tasks
@teogor teogor closed this as completed in #96 Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teogor teogor

Labels
components Marks an Issue/PR as linked to the ceres:components module @feature New feature or request m3 Marks an Issue/PR as linked to the ceres:m3 module @priority-medium
Projects
Open-Source @ Teogor
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated detection algorithm of rippleEnabled for the M3 Components teogor/ceres
2 participants
@teogor @zeoowl-dev