Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to coverage_nightly ? #18

Closed
emarcotte opened this issue Nov 21, 2022 · 1 comment · Fixed by #19
Closed

Switch to coverage_nightly ? #18

emarcotte opened this issue Nov 21, 2022 · 1 comment · Fixed by #19

Comments

@emarcotte
Copy link
Contributor

I was trying to run coverage tests something that depends on this crate and noticed that it fails with:

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> C:\Users\Eugene\.cargo\registry\src\github.com-1ecc6299db9ec823\encase-0.4.0\src\lib.rs:2:23
  |
2 | #![cfg_attr(coverage, feature(no_coverage))]
  |   

According to https://github.com/taiki-e/cargo-llvm-cov#exclude-function-from-coverage this could be solved by a command line flag or a change to checking for coverage_nightly instead of coverage. Would a PR be acceptable to switch to coverage_nightly or is it preferable to use the command line flag for llvm-cov?

@teoxoy
Copy link
Owner

teoxoy commented Nov 27, 2022

I think renaming it to coverage_nightly would be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants