Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot drag the Typora window #1

Closed
ghost opened this issue Mar 8, 2022 · 9 comments
Closed

Cannot drag the Typora window #1

ghost opened this issue Mar 8, 2022 · 9 comments

Comments

@ghost
Copy link

ghost commented Mar 8, 2022

cannot drag the Typora window when using the "Krafty" theme

@TEParsons
Copy link
Owner

The actual window itself? Typora themes are just a CSS stylesheet, so it's strange that it should affect the window... What happens when you try to drag it? Does it just not respond, or do bits stay in place?

@TEParsons TEParsons changed the title A bug Cannot drag the Typora window Mar 8, 2022
@TEParsons TEParsons reopened this Mar 8, 2022
@ghost
Copy link
Author

ghost commented Mar 10, 2022

When I change the Typora theme from Github or others to Krafty, the window becomes stationary. So I couldn't drag it as much as I wanted.

@TEParsons
Copy link
Owner

Does the window then become moveable again when you switch back to Github?

@ghost
Copy link
Author

ghost commented Mar 11, 2022

Yes, it does.

@TEParsons
Copy link
Owner

What operating system and version of Typora are you using? I'll need to recreate this error before I can fix it - and I can move the window around with no trouble on my (Windows 10, Typora 1.1.5) setup

@ghost
Copy link
Author

ghost commented Mar 12, 2022

Typora 1.1.5 for Windows 10, too.
And here is a GIF to show the phenomenon.
GIF 2022-3-12 13-15-11

@TEParsons
Copy link
Owner

Ah I see, you've got appearance set to unibody - that's why I couldn't recreate the error, I have mine in Classic. If I set mine to unibody it does that too, so now I can replicate the error I can figure out what's causing it

@ghost
Copy link
Author

ghost commented Mar 14, 2022

Nice! Thanks for your time.

@TEParsons
Copy link
Owner

Found the bug! Essentially, to make the background stick in place, I set its position to fixed and its top position to 0 - in Unibody mode, the window bar is actually a part of the HTML of the page, so when I set top to 0 it positions the background over the hitbox for the window bar.

I'll actually raise this as an issue on the Typora GitHub too, as I bet there's a way to ensure that the context of the content object is fully independent of the window itself, to avoid novices like me accidentally breaking the window :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant