Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to sync created files from Linux host due to inotify bug #330

Closed
hoatle opened this issue Jun 20, 2017 · 7 comments
Closed

failed to sync created files from Linux host due to inotify bug #330

hoatle opened this issue Jun 20, 2017 · 7 comments

Comments

@hoatle
Copy link
Member

hoatle commented Jun 20, 2017

egor.k [2:05 AM] 
@hoatle hello again
There is a bug I think, when I create a migration file (I usually duplicate the last one) and then modify it, it doesn't synchronize with virtual machine.
Like this:
1. copy the last migration (with a new folder name of course) - sync works
2. make changes in a new migration's `up.sql` file - sync doesn't work anymore for this file

`vagrant reload` helps, but maybe there is a known way to force all files sync manually or something like this, that doesn't involve rebuild?
I don't create migrations often so it's no very important (edited)

hoatle [7:32 AM] 
thank you @egor.k, sync should work, @phuong please help checking on this

phuong [8:52 AM] 
ok

after triaging, @phuonglm found out that it was a inotify bug and @phuonglm will continue to handle this.

Hopefully this can be fixed by v0.5.0-c1

@hoatle
Copy link
Member Author

hoatle commented Jun 20, 2017

phuonglm [10:37 AM] 
bug found

[10:37] 
https://github.com/guard/rb-inotify/blob/master/lib/rb-inotify/notifier.rb#L208

[10:37] 
bug only on Linux

[10:38] 
because inotify on linux did not support recursive

[10:38] 
and the lib used recursive to add all sub directories into the watch list

[10:39]
and the new sub directories was not added to the watch list => bug

@hoatle
Copy link
Member Author

hoatle commented Jun 20, 2017

hoatle [6:50 PM] 
@egor.k I guess the workaround is: stop the rsync watch and then `$ vagrant gatling-rsync-auto` instead of `$ vagrant reload`, @phuong could you confirm this workaround?

phuong [6:50 PM] 
yes, that workaround worked

hoatle [6:51 PM] 
@egor.k please use that workaround until we fix it, thank you.

@hoatle hoatle modified the milestones: v0.5.0, v0.5.0-c1-dev Jul 14, 2017
@hoatle
Copy link
Member Author

hoatle commented Jul 14, 2017

move this issue out of v0.5.0-c1 release, it requires more workload than expected.

@phuonglm
Copy link
Contributor

related issues guard/rb-inotify#75

@hoatle
Copy link
Member Author

hoatle commented Jul 19, 2017

@duc4nh maybe you could help on this?

@hoatle hoatle modified the milestones: v0.5.0-c2-dev, v0.5.0-dev Jul 24, 2017
@hoatle hoatle assigned ducng0610 and unassigned phuonglm Jul 24, 2017
@hoatle hoatle removed the sprt:next label Aug 15, 2017
@hoatle hoatle assigned phuonglm and unassigned ducng0610 Sep 9, 2017
@hoatle
Copy link
Member Author

hoatle commented Aug 17, 2018

this should be the bug fix from extension, so close.

@hoatle
Copy link
Member Author

hoatle commented Nov 22, 2018

This issue was moved to teracyhq-incubator/teracy-dev-essential#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants