Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel image ratio #283

Merged
merged 1 commit into from
May 21, 2024
Merged

Carousel image ratio #283

merged 1 commit into from
May 21, 2024

Conversation

wazolab
Copy link
Contributor

@wazolab wazolab commented May 13, 2024

No description provided.

@wazolab wazolab added the bug Something isn't working label May 13, 2024
@wazolab wazolab requested a review from frodrigo May 13, 2024 13:50
@wazolab wazolab self-assigned this May 13, 2024
@wazolab wazolab linked an issue May 13, 2024 that may be closed by this pull request
@wazolab wazolab added this to the v1.23 milestone May 13, 2024
@wazolab wazolab force-pushed the 127-detail-bad-image-size branch from 0b8af45 to 73e55e0 Compare May 15, 2024 15:02
@wazolab
Copy link
Contributor Author

wazolab commented May 15, 2024

I created a separate Issue for srcset checks.
I need to read more informations about this feature and how it's supposed to be handled in Nuxt.

@frodrigo
Copy link
Member

The image does not respect the ratio 16/9.

I have nothing again the current displayed ratio here. But not match the aim of this PR.

http://haute_vienne.localtest.me:3000/poi/29285/details

image

image

@wazolab wazolab force-pushed the 127-detail-bad-image-size branch from 73e55e0 to a4a6c4d Compare May 16, 2024 12:37
@frodrigo frodrigo merged commit b944f47 into develop May 21, 2024
5 checks passed
@wazolab wazolab deleted the 127-detail-bad-image-size branch June 24, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[detail] Bad image size
2 participants