Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[detail] Bad image size #127

Closed
frodrigo opened this issue Aug 2, 2023 · 5 comments · Fixed by #283
Closed

[detail] Bad image size #127

frodrigo opened this issue Aug 2, 2023 · 5 comments · Fixed by #283
Assignees
Labels
bug Something isn't working
Milestone

Comments

@frodrigo
Copy link
Member

frodrigo commented Aug 2, 2023

http://127.0.0.1:3000/poi/33729/details

http://127.0.0.1:3000/poi/33713/details

image

@frodrigo frodrigo added the bug Something isn't working label Aug 2, 2023
@frodrigo frodrigo added this to the v1.21 milestone Aug 2, 2023
@frodrigo frodrigo self-assigned this Aug 2, 2023
@frodrigo frodrigo modified the milestones: v1.21, v1.22 Oct 5, 2023
@frodrigo frodrigo modified the milestones: v1.22, v1.23 Mar 18, 2024
@wazolab
Copy link
Contributor

wazolab commented May 6, 2024

@frodrigo : Is this an image ratio issue ? Do we want to fix it to a specific one ? :

  • 16:9
  • 1:1
  • 4:3

An other issue is the ratio of the image served from the API, if we display landscapes images but receive portrait from API, we will have to constraint the portrait within our frame and scale-down the image.

Example here of a portrait image (I greyed the background of our landscape frame for a better understanding only) :

image

Example here of a landscape image :

image

@frodrigo
Copy link
Member Author

frodrigo commented May 7, 2024

My previous attempt was to fill width and height (I think with "cover" option).

@wazolab
Copy link
Contributor

wazolab commented May 7, 2024

Alright, if we fill width & height and apply object-fit: cover we might have croped images...

More globally, we have to define a frame to ensure a constant layout.

@wazolab
Copy link
Contributor

wazolab commented May 13, 2024

@frodrigo : Is this an image ratio issue ? Do we want to fix it to a specific one ? :

  • 16:9
  • 1:1
  • 4:3

An other issue is the ratio of the image served from the API, if we display landscapes images but receive portrait from API, we will have to constraint the portrait within our frame and scale-down the image.

Example here of a portrait image (I greyed the background of our landscape frame for a better understanding only) :

image

Example here of a landscape image :

image

Do the solutions I have presented here suit you?

@frodrigo
Copy link
Member Author

Alright, if we fill width & height and apply object-fit: cover we might have croped images...

Yes, it was like this before.

wazolab added a commit that referenced this issue May 13, 2024
@wazolab wazolab linked a pull request May 13, 2024 that will close this issue
wazolab added a commit that referenced this issue May 15, 2024
wazolab added a commit that referenced this issue May 16, 2024
frodrigo pushed a commit that referenced this issue May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants