-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[detail] Bad image size #127
Comments
@frodrigo : Is this an image ratio issue ? Do we want to fix it to a specific one ? :
An other issue is the ratio of the image served from the API, if we display landscapes images but receive portrait from API, we will have to constraint the portrait within our frame and scale-down the image. Example here of a portrait image (I greyed the background of our landscape frame for a better understanding only) : Example here of a landscape image : |
My previous attempt was to fill width and height (I think with "cover" option). |
Alright, if we fill width & height and apply object-fit: cover we might have croped images... More globally, we have to define a frame to ensure a constant layout. |
Do the solutions I have presented here suit you? |
Yes, it was like this before. |
http://127.0.0.1:3000/poi/33729/details
http://127.0.0.1:3000/poi/33713/details
The text was updated successfully, but these errors were encountered: