move sdk version configs to gradle.properties (#1685)

termux · Aug 4, 2020 · 04268f4 · 04268f4
1 parent 6f24628
commit 04268f4
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 11 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -3,8 +3,8 @@ plugins {
 }
 
 android {
-    compileSdkVersion 28
-    ndkVersion '21.3.6528147'
+    compileSdkVersion project.properties.compileSdkVersion.toInteger()
+    ndkVersion project.properties.ndkVersion
 
     dependencies {
         implementation "androidx.annotation:annotation:1.1.0"
@@ -15,8 +15,8 @@ android {
 
     defaultConfig {
         applicationId "com.termux"
-        minSdkVersion 24
-        targetSdkVersion 28
+        minSdkVersion project.properties.minSdkVersion.toInteger()
+        targetSdkVersion project.properties.targetSdkVersion.toInteger()
         versionCode 96
         versionName "0.96"
 

diff --git a/gradle.properties b/gradle.properties
@@ -14,3 +14,8 @@
 # org.gradle.parallel=true
 org.gradle.jvmargs=-Xmx2048M
 android.useAndroidX=true
+
+minSdkVersion=24
+targetSdkVersion=28
+ndkVersion=21.3.6528147
+compileSdkVersion=28
diff --git a/terminal-emulator/build.gradle b/terminal-emulator/build.gradle
@@ -17,12 +17,12 @@ ext {
 }
 
 android {
-    compileSdkVersion 28
-    ndkVersion '21.3.6528147'
+    compileSdkVersion project.properties.compileSdkVersion.toInteger()
+    ndkVersion project.properties.ndkVersion
 
     defaultConfig {
-        minSdkVersion 21
-        targetSdkVersion 28
+        minSdkVersion project.properties.minSdkVersion.toInteger()
+        targetSdkVersion project.properties.targetSdkVersion.toInteger()
 
         externalNativeBuild {
             ndkBuild {

diff --git a/terminal-view/build.gradle b/terminal-view/build.gradle
@@ -17,16 +17,16 @@ ext {
 }
 
 android {
-    compileSdkVersion 28
+    compileSdkVersion project.properties.compileSdkVersion.toInteger()
 
     dependencies {
         implementation "androidx.annotation:annotation:1.1.0"
         api project(":terminal-emulator")
     }
 
     defaultConfig {
-        minSdkVersion 21
-        targetSdkVersion 28
+        minSdkVersion project.properties.minSdkVersion.toInteger()
+        targetSdkVersion project.properties.targetSdkVersion.toInteger()
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }