-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an "Autofill password" context menu action #1664
Conversation
Seems like a useful feature, I think @fornwall just needs to sign off. |
Is there anything blocking the merge of this? |
@buttaface go for it, as long as it is tested and no obvious side-effects can be found, it should be fine |
Will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello world
This looks really nice - thanks! |
Sorry about the delay. The patch seemed fine to me, but I just wanted to find another device on which I could run this apk and test the feature, but never got around to that. |
This is a nice feature, but I was wondering if it would work the other way?
I use a CLI password manager ( |
It will not. The code here invokes the system Autofill framework, and does not actually involve the clipboard at all so copying to and from it isn't related to this PR at all. Do you have a specific reason to go through all the pain of using the pass CLI on Android rather than a dedicated client for pass like android-password-store/android-password-store? If the app is lacking something then I'd like to know. |
@msfjarvis |
It would help users if they were able to let their password managers enter passwords into terminal sessions for them. While there are legacy solutions for this that already work with Termus (accessibility services and custom IMEs), as of Android Oreo, the preferred method for this usecase is using the system-provided Autofill API.
This commit adds a context menu action that sends a password field Autofill request to the currently registered Autofill service. Triggering the Autofill UI requires an explicit user action (due to
importantForAutofill="no"
) and the context menu action is only shown when Autofill is both supported and enabled.