Skip to content

Commit

Permalink
2048-c: Fix description string
Browse files Browse the repository at this point in the history 
This basically broke the JSON data for repology which made Repology to not reflect any changes in the repo
  • Loading branch information
@thunder-coding
thunder-coding committed Feb 3, 2022
1 parent 5c1a05b commit b760237
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/2048-c/build.sh
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
TERMUX_PKG_HOMEPAGE=https://github.com/mevdschee/2048.c
TERMUX_PKG_DESCRIPTION="Console version of the game \"2048\" for GNU/Linux"
TERMUX_PKG_DESCRIPTION="Console version of the game '2048' for GNU/Linux"
TERMUX_PKG_LICENSE="MIT"
_COMMIT=bdb7527db2c4b5ce5eb8b8067ed9c0330ead77ea
TERMUX_PKG_MAINTAINER="@termux"
TERMUX_PKG_VERSION=2021.04.22
TERMUX_PKG_REVISION=1
TERMUX_PKG_SRCURL=https://github.com/mevdschee/2048.c.git
TERMUX_PKG_GIT_BRANCH=main
TERMUX_PKG_BUILD_IN_SRC=true
Expand Down

3 comments on commit b760237

@AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented on b760237 Feb 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the repology-metadata script be fixed instead to generate JSON in a reliable way?
Also, could the script include an URL of the repository a package comes from? This is required for Repology to be able to constuct a link to package sources, and is now mandatory.
Also would be nice to enable issues for https://github.com/termux/repology-metadata

@Grimler91
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the repology-metadata script be fixed instead to generate JSON in a reliable way?

The script has some room for improvements for sure.

Also, could the script include an URL of the repository a package comes from?

What should such a variable be called in the packages.json?
Do you mean a link to the root of the repo (for example https://github.com/termux/termux-packages), or a link to the package folder (for example https://github.com/termux/termux-packages/tree/master/packages/0verkill)?

Also would be nice to enable issues for https://github.com/termux/repology-metadata

It has now been enabled

@AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented on b760237 Feb 7, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should such a variable be called in the packages.json?

At your discretion, maybe something like repository_url.

Do you mean a link to the root of the repo (for example https://github.com/termux/termux-packages), or a link to the package folder (for example https://github.com/termux/termux-packages/tree/master/packages/0verkill)?

Well as of now, Repology usually constructs three links for a package as long as these are valid:

So it needs just enough information in order to be able to construct these links.

Repo root thus would generally be enough, but here it will only work if all repositories reside on GitHub and all packages reside under packages/{name}, and I'm not sure if that's true.

Even if these conditions are fulfilled, it's not quite future-proof, and, given that this script is designated specifically for Repology, it may be more convenient to construct all three links right away, e.g.

   "package_sources_url": "https://github.com/termux/termux-packages/tree/master/packages/0verkill",
   "package_recipe_url": "https://github.com/termux/termux-packages/blob/master/packages/0verkill/build.sh",
   "package_recipe_raw_url": "https://raw.githubusercontent.com/termux/termux-packages/master/packages/0verkill/build.sh"

Taking advantage of the opportunity, it would be nice to also have links to patches:

   "package_patch_urls": ["https://github.com/termux/termux-packages/blob/master/packages/binutils/binutils.patch"],
   "package_patch_raw_urls": ["https://raw.githubusercontent.com/termux/termux-packages/master/packages/binutils/binutils.patch"]

It has now been enabled

Thank you!

Please sign in to comment.