Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Make TERMUX_API_VERSION available in ssh #16748

Closed
qirlib opened this issue May 22, 2023 · 5 comments
Closed

[Feature]: Make TERMUX_API_VERSION available in ssh #16748

qirlib opened this issue May 22, 2023 · 5 comments
Assignees
@sylirre
Labels
enhancement

Comments

@qirlib
Copy link

qirlib commented May 22, 2023

Feature description

TERMUX_API_VERSION is not available in ssh and, if I understand correctly, other non-interactive shells. It probably should be as TERMUX_VERSION is.

P. S. Is TERMUX_API_VERSION still the way to check if Termux:API is installed or should I just command -v termux-am? There's a mention termux/termux-app#2961 (comment) it's been renamed.

Additional information

N/A.
@It087

This comment was marked as spam.

Sign in to view
@sylirre sylirre transferred this issue from termux/termux-app May 23, 2023
@sylirre sylirre self-assigned this May 23, 2023
WTNLXTBL added a commit to WTNLXTBL/termux-packages-pacman that referenced this issue May 23, 2023
@WTNLXTBL
fix(main/openssh): revise list of kept variables
644c95b 
Changes:

* Added many new variables exported by Termux app.
* Removed LD_LIBRARY_PATH - this shouldn't be set on Android 7+ Termux.
                            Users can set this variable in bashrc.

Closes termux/termux-packages#16748
@sylirre
Copy link
Member

sylirre commented May 23, 2023

After 1b570d2 openssh should set the Termux variables including TERMUX_API_VERSION if the variables were set in the session where sshd was started.

Depending on Termux version used, one or more variables may not be present. Also note that git version of Termux is not complete.

WTNLXTBL added a commit to WTNLXTBL/termux-packages that referenced this issue May 23, 2023
@WTNLXTBL
fix(main/openssh): revise list of kept variables
e7fa6d7 
Changes:

* Added many new variables exported by Termux app.
* Removed LD_LIBRARY_PATH - this shouldn't be set on Android 7+ Termux.
                            Users can set this variable in bashrc.

Closes termux/termux-packages#16748
@agnostic-apollo
Copy link
Member

agnostic-apollo commented May 23, 2023 •
edited

Would be better to just export all variables that start with TERMUX__, TERMUX_APP__, TERMUX_API_APP__, TERMUX_FLOAT_APP__, TERMUX_TASKER_APP__, TERMUX_WIDGET_APP__, TERMUX_GUI_APP__ and TERMUX_X11_APP__ so that package doesn't need to be updated whenever new variables are added.

@sylirre
Copy link
Member

sylirre commented May 23, 2023

Ok, will change it to keep variables with given prefixes.

sylirre added a commit that referenced this issue May 23, 2023
@sylirre
fix(main/openssh): don't hardcode variables to keep where possible
663b1c0 
Always keep environment variables starting with ANDROID_ and TERMUX_.

Issue #16748
WTNLXTBL added a commit to WTNLXTBL/termux-packages-pacman that referenced this issue May 23, 2023
@WTNLXTBL
fix(main/openssh): don't hardcode variables to keep where possible
ec5819c 
Always keep environment variables starting with ANDROID_ and TERMUX_.

Issue termux/termux-packages#16748
WTNLXTBL added a commit to WTNLXTBL/termux-packages that referenced this issue May 23, 2023
@WTNLXTBL
fix(main/openssh): don't hardcode variables to keep where possible
87e4c3a 
Always keep environment variables starting with ANDROID_ and TERMUX_.

Issue termux/termux-packages#16748
@agnostic-apollo
Copy link
Member

Thanks

termux-pacman-bot added a commit to termux-pacman/termux-packages that referenced this issue May 28, 2023
@termux-pacman-bot
fix(main/openssh): don't hardcode variables to keep where possible
cc03214 
Always keep environment variables starting with ANDROID_ and TERMUX_.

Issue termux/termux-packages#16748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylirre sylirre

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@qirlib @agnostic-apollo @sylirre @It087