Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to be made when updating to NDK r17 #1905

Closed
enh opened this issue Dec 5, 2017 · 4 comments
Closed

Changes to be made when updating to NDK r17 #1905

enh opened this issue Dec 5, 2017 · 4 comments
Labels
information Informational post.

Comments

@enh
Copy link

enh commented Dec 5, 2017

an NDK r17 with https://android-review.googlesource.com/#/c/platform/bionic/+/555419/ didn't need your <sys/select.h> patch, so hopefully you should be able to get rid of that when r17 ships. just filing this bug as a future reminder for you :-)
@fornwall fornwall added the information Informational post. label Dec 5, 2017
@fornwall fornwall changed the title NDK r17 should make the <sys/select.h> patch obsolete Changes to be made when updating to NDK r17 Dec 5, 2017
@fornwall
Copy link
Member

fornwall commented Dec 5, 2017

Let's generalize this to a tracking bug to prepare for NDK r17. So far we have:

@fornwall fornwall mentioned this issue Dec 5, 2017
Closed
@Grimler91
Copy link
Member

Considering the latest comments in android/ndk#294 we might be able to build emacs and m4 with clang instead of with gcc in r17 as well.

@fornwall
Copy link
Member

  • AArch64 now uses gold by default, matching the other architectures - we can remove the lines in build-package.sh that sets up gold as the default linker.

@fornwall
Copy link
Member

fornwall commented Apr 8, 2018

vladimiroltean added a commit to vladimiroltean/termux-packages that referenced this issue May 3, 2018
@vladimiroltean
ndk r17-beta2 upgrade: initial commit
87ee5fa 
* Upgrading is needed in order to fix the stupid situation we're in
  with docker-tini:
  * Needs to have API >= 23 for sigtimedwait
    (termux#899)
  * Needs to have API <= 21 for static linking
    (android/ndk#272)
* The latter of the 2 above restrictions was removed in NDK r17, so
  that's why we're upgrading.
* The other changes (removed headers and patches) are according to
  Mr. Fornwall himself:
  termux#1905

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
vladimiroltean added a commit to vladimiroltean/termux-packages that referenced this issue May 3, 2018
@vladimiroltean
ndk r17-beta2 upgrade: initial commit
bf75ab1 
* Upgrading is needed in order to fix the stupid situation we're in
  with docker-tini:
  * Needs to have API >= 23 for sigtimedwait
    (termux#899)
  * Needs to have API <= 21 for static linking
    (android/ndk#272)
* The latter of the 2 above restrictions was removed in NDK r17, so
  that's why we're upgrading.
* The other changes (removed headers and patches) are according to
  Mr. Fornwall himself:
  termux#1905

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
vladimiroltean added a commit to vladimiroltean/termux-packages that referenced this issue May 3, 2018
@vladimiroltean
ndk r17-beta2 upgrade: initial commit
6f477f2 
* Upgrading is needed in order to fix the stupid situation we're in
  with docker-tini:
  * Needs to have API >= 23 for sigtimedwait
    (termux#899)
  * Needs to have API <= 21 for static linking
    (android/ndk#272)
* The latter of the 2 above restrictions was removed in NDK r17, so
  that's why we're upgrading.
* The other changes (removed headers and patches) are according to
  Mr. Fornwall himself:
  termux#1905

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
@vishalbiswas vishalbiswas mentioned this issue May 10, 2018
Merged
@termux termux locked and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
information Informational post.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fornwall @enh @Grimler91