Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(recoll): configure without --disable-python-module #12497

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Oct 23, 2022

This PR builds on #12299 to enable Python support in the recoll package. Hopefully also fixes koniu/recoll-webui#86.

Copy link
Member

@2096779623 2096779623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

  • Please bump revision (TERMUX_PKG_REVISION=1)
  • Try specifying python version without hardcoded paths, example:
    _PYTHON_VERSION=$(source $TERMUX_SCRIPTDIR/packages/python/build.sh; echo $_MAJOR_VERSION)

@JCGoran
Copy link
Contributor Author

JCGoran commented Oct 24, 2022

Thanks for the PR!

  • Please bump revision (TERMUX_PKG_REVISION=1)

Done.

Done, now the patching isn't necessary.

P.S. I didn't know whether you'd prefer me to push additional commits, or rebase, so I opted for the first one, but I can squash it into one commit if you'd prefer.

@2096779623
Copy link
Member

2096779623 commented Oct 24, 2022

Good! need to rewrite this commit message, add recoll: in front or squash :) .

@JCGoran
Copy link
Contributor Author

JCGoran commented Oct 24, 2022

Rebased on latest master and squashed into one commit.

Copy link
Member

@2096779623 2096779623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recoll WebUi - Need one for mobile
2 participants