Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addpkg(main/crystal): Crystal 1.9.0 #17428

Merged
merged 6 commits into from
Jul 15, 2023
Merged

addpkg(main/crystal): Crystal 1.9.0 #17428

merged 6 commits into from
Jul 15, 2023

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Jul 13, 2023 •
edited

This adds the Crystal compiler plus its Shards package manager. Only AArch64, off-device builds are tested. See also #8265

Fixes #3401

@HertzDevil HertzDevil changed the title New package: Crystal 1.9.0 addpkg(main/crystal): Crystal 1.9.0 Jul 13, 2023
truboxl
truboxl reviewed Jul 14, 2023
View reviewed changes
packages/crystal/build.sh Outdated Show resolved Hide resolved
truboxl
truboxl reviewed Jul 14, 2023
View reviewed changes
packages/crystal/build.sh Outdated Show resolved Hide resolved
truboxl
truboxl approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@truboxl truboxl left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Lets see others got any reviews, otherwise I will merge by today.

@HertzDevil
Copy link
Contributor Author

An addendum: libffi is recommended because the compiler's interpreter functionality depends on it, but it isn't exposed in the standard library API. This package doesn't enable it because the interpreter itself is an experimental feature, but people could rebuild the compiler on Termux with the source tree, enabling the interpreter, in which case libffi is linked against

@truboxl truboxl merged commit 5115fa9 into termux:master Jul 15, 2023
@HertzDevil HertzDevil deleted the crystal branch October 11, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@truboxl truboxl truboxl approved these changes

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

@finagolfin finagolfin Awaiting requested review from finagolfin finagolfin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: Crystal
2 participants
@HertzDevil @truboxl