Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new packages: shotcut, mlt and their deps #20353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

knyipab
Copy link
Contributor

@knyipab knyipab commented May 29, 2024

Draft PR. currently the app mostly works well but cannot output video results, perhaps there are problems with QProcess, see #20354 . [fixed]

Other things to note:

x11-packages/shotcut/build.sh Outdated Show resolved Hide resolved
@knyipab
Copy link
Contributor Author

knyipab commented May 31, 2024

This package will be ready and I will force-push it once #20352 and #20374 are merged.
The sound effects should work with sdl2 package. jack-dummy is more for runtime purpose (won't produce sound) otherwise need to patch the code. rtaudio is a longer run TODO item when pipewire is in a good state. opencv is nice-to-have item if someone find a fix but that shouldn't matter much.

@TomJo2000
Copy link
Member

This package will be ready and I will force-push it once #20352 and #20374 are merged. The sound effects should work with sdl2 package. jack-dummy is more for runtime purpose (won't produce sound) otherwise need to patch the code. rtaudio is a longer run TODO item when pipewire is in a good state. opencv is nice-to-have item if someone find a fix but that shouldn't matter much.

Please make sure to add

termux_step_pre_configure(){
	CXXFLAGS+=' -Wno-c++11-narrowing'
}

to make sure the 32 bit builds succeed.

@knyipab
Copy link
Contributor Author

knyipab commented May 31, 2024

Thanks and will do when movit is available

@TomJo2000
Copy link
Member

In that case I'm gonna go ahead and merge movit.

@knyipab knyipab marked this pull request as ready for review June 1, 2024 01:37
@knyipab
Copy link
Contributor Author

knyipab commented Jun 1, 2024

Tested on my aarch64 phone. Import playlist, track editor, preview, some basic filters (rotate, opacity), export work.

Ready to be merged. See if you are fine with the way I patch the source code.

@truboxl
Copy link
Contributor

truboxl commented Jun 1, 2024

Please change all the .patch files that hardcoded with /data/data/com.termux/files/usr to @TERMUX_PREFIX@

@knyipab
Copy link
Contributor Author

knyipab commented Jun 1, 2024

fixed. thanks

@Biswa96
Copy link
Member

Biswa96 commented Jun 1, 2024

x11-packages/mlt/0001-cmake-mlt-undefined-version.patch and x11-packages/mlt/0002-cmake-mlt++-undefined-version.patch are probably not required. The issue can be fixed with LDFLAGS+=" -Wl,--undefined-version" (see packages/zlib/build.sh).

@knyipab
Copy link
Contributor Author

knyipab commented Jun 1, 2024

Thanks @Biswa96 . You are right and force-pushed.

@truboxl
Copy link
Contributor

truboxl commented Jun 2, 2024

Please change TERMUX_PKG_MAINTAINER field

@knyipab
Copy link
Contributor Author

knyipab commented Jun 2, 2024

oh right, fixed.

x11-packages/mlt/build.sh Outdated Show resolved Hide resolved
@knyipab
Copy link
Contributor Author

knyipab commented Jun 25, 2024

@truboxl refactored: addressed your comments, used the jack merged in #20544, removed TODO, and removed the libjack.so.0 patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants