ndk-patches: use upstream ifaddrs.h and remove old syslog.h polyfills #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we really need to hide There recently was a related issue - #4643. |
|
Seems like it was hidden a couple years ago when support for it wasn't that great, 2173f73, hopefully should be better by now. I can remove that too as part of this pull if you like. |
ghost
merged commit 
|
Thanks @buttaface, nice cleanup! |
fornwall
added a commit
that referenced
this pull request
Dec 29, 2019
After #4639 has been merged linking against liblog for syslog-using code is no longer needed.
Grimler91
added a commit
to termux/termux-root-packages
that referenced
this pull request
Jan 11, 2020
Also remove no longer needed LIBS=-llog after termux/termux-packages#4639
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that this branch requires at least API 24, no need to supply an ifaddrs implementation anymore. Similar for syslog, its polyfills were added when this repo was first started, but most were implemented upstream similarly around the same time. I think the syslog_r/vsyslog_r declarations should just be thrown out, rather than simply forwarding to vsyslog, but I don't know if that would break anything, so I kept it for now.
I haven't tested this by building any packages, since I don't know which packages rely on them, so that should be done by the CI. I also haven't bothered bumping the sysroot/toolchain versions, as there's no hurry on this, can just be merged with the upcoming NDK 21 release.