Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zile: fix and enable #56

Closed
wants to merge 2 commits into from
Closed

zile: fix and enable #56

wants to merge 2 commits into from

Conversation

iainnicol
Copy link
Contributor

Yay.

@iainnicol
zile: fix segfault at startup
994ce15 
The segfault was occurring because malloc() was failing to use the
garbage collector's API.

I find this fix a bit ugly.  However, the good news is that zile
master seems to no longer need this fix.  There's no obvious and
simple fix to backport from master, however.  I think zile master
works because its gnulib dependency has been upgraded.  The fix here
is simpler than bumping gnulib.
@iainnicol
zile: enable this package
b40cb6d 
It works for me, now.

Zile is the closest thing I have to Emacs on my phone.  Yay!
fornwall added a commit that referenced this pull request Nov 15, 2015
@fornwall
Enable the zile package
89df552 
The zile package no longer crashes after @iainnicol finding out
that the issue was rpl_malloc, so enable it.

See #56
@fornwall
Copy link
Member

Nice find about rpl_malloc!

I've now added the necessary configure arguments to prevent rpl_malloc from being generated globally to build-packages.sh in 150f95a, so we no longer need to patch malloc.c! I've also added a pre-built man page to avoid requiring a host build, since a host build requires builders to have a new package (libgc-dev) to be installed (which is nice to avoid if possible).

The enabling commit was done in 89df552, and the package has been built and added it to the apt repository (so apt install zile works, as long as one has updated the package index with apt update).

Once again, really nice find with rpl_malloc, this will enable future libgc-using packages to use without crashing :).

@fornwall fornwall closed this Nov 15, 2015
@iainnicol iainnicol deleted the zile branch November 15, 2015 23:04
@iainnicol
Copy link
Contributor Author

Oh, sweet! I had no idea a more elegant fix was possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iainnicol @fornwall