Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: remove fix-GenericAlias patch #7433

Merged
merged 1 commit into from
Aug 30, 2021
Merged

python: remove fix-GenericAlias patch #7433

merged 1 commit into from
Aug 30, 2021

Conversation

Grimler91
Copy link
Member

It does not seem to be necessary any more, and it causes issues:
#7432

It does not seem to be necessary any more, and it causes issues:
#7432
@Grimler91
Copy link
Member Author

@landfillbaby do you remember what the error/issue was when you added the patch? The old CI logs cannot be downloaded anymore

@landfillbaby
Copy link
Member

landfillbaby commented Aug 30, 2021

i think i got the patch from this debian bug
and looking at that thread now, the patch i used was wrong to begin with, it should have been _CallableGenericAlias(type(list[int])) rather than _CallableGenericAlias(list[int])
i think the actual underlying problem was building python 3.9 and then testing its stdlib using the host system's 3.8 or 3.7, so this should definitely be merged

@landfillbaby landfillbaby merged commit 9d4304f into master Aug 30, 2021
@landfillbaby landfillbaby deleted the python-fix branch August 30, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants