nodejs: Bump to 16.11.0 #7710
Merged
nodejs: Bump to 16.11.0 #7710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, in my commit message I wrote |
|
The earlier |
Other changes done: - Removed `no-android-log.patch` since Node.js uses GYP and not GN to build itself. This patch must be having no effect at all - Added patch to force `V8_TRAP_HANDLER_SUPPORTED` to always false which fixes builds for x86_64 which started reproducing even on aarch64 - Removed `x86_64` as blacklisted arch
|
Ready to merge. The previous CI passed and the debs also seem to be well ✅ |
ghost
added
the
metayan
pushed a commit
to metayan/termux-packages
that referenced
this pull request
Nov 28, 2021
Other changes done: - Removed `no-android-log.patch` since Node.js uses GYP and not GN to build itself. This patch must be having no effect at all - Added patch to force `V8_TRAP_HANDLER_SUPPORTED` to always false which fixes builds for x86_64 which started reproducing even on aarch64 - Removed `x86_64` as blacklisted arch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes done:
no-android-log.patchsince Node.js uses GYP and not GN tobuild itself. This patch must be having no effect at all
V8_TRAP_HANDLER_SUPPORTEDto always false which fixes builds for x86_64 which started reproducing even on aarch64x86_64as blacklisted archSince we have got how to fix builds for nodejs for x86_64 let's port this fix to nodejs-lts too 🤞
Manual Tests to be done