Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to note if an identifier came from built-in definitions versus source #48

Closed
petetronic opened this issue Apr 11, 2013 · 2 comments

Comments

@petetronic
Copy link
Contributor

It would be helpful to have a flag in the completions response data that would allow us to note which identifiers came from the .json defs and which were from user .js source files (to help categorize globals as being user code or built-in).

@marijnh
Copy link
Member

marijnh commented Apr 12, 2013

In patch 503b1ca and 7678c5b I've added support for getting 'origins' with completions, which are the filename that a thing comes from or the !name field of the def file it was loaded in.

You could associate custom icons with the names of the def files that you loaded. Does that help?

@petetronic
Copy link
Contributor Author

Thanks - this information worked for us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants