Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update provider to v4.x, add new attributes from v4.x, change user_data_base64 to user_data #186

Merged
merged 2 commits into from
Apr 3, 2022

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Apr 2, 2022

Description

  • Update provider to v4.x to support attributes added
  • Change user_data_base64 to user_data to match resource name used
  • Add capacity_reservation_resource_group_arn attribute to capacity_reservation_specification.capacity_reservation_target
  • Add ipv4_prefix_count, ipv4_prefixes, ipv6_prefix_count, ipv6_prefixes to network_interfaces
  • Add private_dns_name_options block and its attributes
  • Add instance_reuse_policy block and its attributes to warm_pool

Motivation and Context

  • Updates module to use latest features offered in v4.x provider
  • Variable name change made to align with resource name spec (was a legacy name that looks to have been missed in prior breaking change)
  • Pulling this module up to be as current as possible before using in EKS module v19.x
    • This module will create the launch template and ASG for the EKS self managed node group, the launch template for the EKS managed node group, and probably add the option to create a launch template with user data rendered for use with Karpenter which handles cluster compute scaling using launch template). This will also give users of self managed node groups the ability to control desired size or not, which has been requested quite a bit
  • Closes fix: Errors on ignore_desired_capacity_changes = true with mixed_instances_policy #183
  • Closes fix: Issue with aws_autoscaling_policy SimpleScaling #184

Breaking Changes

  • Yes; provider major version bump and one variable name change - no state manipulations required

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

…nge `user_data_base64` to `user_data_base64`
@antonbabenko antonbabenko changed the title feat!: Update provider to v4.x, add new attributes from v4.x, change user_data_base64 to user_data_base64 feat!: Update provider to v4.x, add new attributes from v4.x, change user_data_base64 to user_data Apr 3, 2022
@antonbabenko antonbabenko merged commit 8e2e285 into terraform-aws-modules:master Apr 3, 2022
antonbabenko pushed a commit that referenced this pull request Apr 3, 2022
## [6.0.0](v5.2.0...v6.0.0) (2022-04-03)

### ⚠ BREAKING CHANGES

* Update provider to `v4.x`, add new attributes from `v4.x`, change `user_data_base64` to `user_data` (#186)

### Features

* Update provider to `v4.x`, add new attributes from `v4.x`, change `user_data_base64` to `user_data` ([#186](#186)) ([8e2e285](8e2e285))
@antonbabenko
Copy link
Member

This PR is included in version 6.0.0 🎉

@bryantbiggs bryantbiggs deleted the feat/provider-v4 branch April 3, 2022 11:13
@danielkza
Copy link

This completely broke warm_pool option by giving it the wrong type. It is not a map with string values. How did this go unnoticed?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants