Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add depends_on policy and policy attachments for pipes #133

Merged

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Sep 1, 2024

Description

Pipes requires permissions for source and target actions to be attached prior to creation otherwise the following error occurs (example of one from examples/with-pipes):

╷
│ Error: waiting for creation AWS EventBridge Pipes Pipe (sqs-source-lambda-target-pipe): unexpected state 'CREATE_FAILED', wanted target 'RUNNING, STOPPED'. last error: Input parameter is invalid from the request due to : The provided customer role does not have permissions to call ReceiveMessage on SQS
│ 
│   with module.eventbridge.aws_pipes_pipe.this["sqs_source_lambda_target"],
│   on ../../main.tf line 611, in resource "aws_pipes_pipe" "this":
│  611: resource "aws_pipes_pipe" "this" {
│ 
╵

Motivation and Context

Permissions are required to be attached to the pipes role prior to creation otherwise error occurs.

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit d4938fc into terraform-aws-modules:master Sep 4, 2024
16 checks passed
antonbabenko pushed a commit that referenced this pull request Sep 4, 2024
## [3.9.1](v3.9.0...v3.9.1) (2024-09-04)

### Bug Fixes

* Add `depends_on` policy and policy attachments for pipes ([#133](#133)) ([d4938fc](d4938fc))
@antonbabenko
Copy link
Member

This PR is included in version 3.9.1 🎉

@magreenbaum magreenbaum deleted the fix/pipes_dependency branch September 5, 2024 00:50
Copy link

github-actions bot commented Oct 5, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants