Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support source_db_instance_automated_backups_arn parameter in restore_to_point_in_time block #398

Merged
merged 3 commits into from
Apr 27, 2022
Merged

feat: Support source_db_instance_automated_backups_arn parameter in restore_to_point_in_time block #398

merged 3 commits into from
Apr 27, 2022

Conversation

comutrex
Copy link
Contributor

@comutrex comutrex commented Apr 27, 2022 •
edited by bryantbiggs
Loading

Description

This adds source_db_instance_automated_backups_arn parameter to the restore_to_point_in_time block in aws_db_instance resource.

Motivation and Context

Ability to use feature added in hashicorp/terraform-provider-aws#23086
Closes #397

Breaking Changes

None

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@bryantbiggs
Copy link
Member

we'll need to bump the minimum supported version of the AWS provider for this change as well

@comutrex
Copy link
Contributor Author

@bryantbiggs Provider version looks okay (>= 4.0), feature was implemented in v4.6.0.

@bryantbiggs
Copy link
Member

@bryantbiggs Provider version looks okay (>= 4.0), feature was implemented in v4.6.0.

It has to be bumped to >= 4.6.0 because if someone is using anything between 4.0 and 4.5 then it will fail for them

@comutrex
Copy link
Contributor Author

@bryantbiggs you're right, my mistake.

@bryantbiggs
Copy link
Member

@comutrex FYI - just bump it consistently across the modules and examples as well, and ensure you run pre-commit run -a after to update the docs

@comutrex
Copy link
Contributor Author

@bryantbiggs AWS provider version bumped.

bryantbiggs
bryantbiggs approved these changes Apr 27, 2022
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @comutrex !

@bryantbiggs bryantbiggs merged commit 559e6b1 into terraform-aws-modules:master Apr 27, 2022
antonbabenko pushed a commit that referenced this pull request Apr 27, 2022
@semantic-release-bot
chore(release): version 4.3.0 [skip ci]
61a9af9 
## [4.3.0](v4.2.0...v4.3.0) (2022-04-27)

### Features

* Support `source_db_instance_automated_backups_arn` parameter in `restore_to_point_in_time` block ([#398](#398)) ([559e6b1](559e6b1))
@antonbabenko
Copy link
Member

This PR is included in version 4.3.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasneves-signifyd jonasneves-signifyd jonasneves-signifyd approved these changes

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for restoration of Automated Backups (just one line change)
4 participants
@comutrex @bryantbiggs @antonbabenko @jonasneves-signifyd