Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct .fifo postfix and KMS key ID usage on dead letter queue #51

Merged
merged 1 commit into from
Jan 19, 2023
Merged

fix: Correct .fifo postfix and KMS key ID usage on dead letter queue #51

merged 1 commit into from
Jan 19, 2023

Conversation

bryantbiggs
Copy link
Member

Description

  • Correct the use of the .fifo postfix regardless of whether the user specifies it or not on dead letter queue
  • Ensure that the KMS key ID is used on the dead letter queue when one is provided

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit 2587a70 into terraform-aws-modules:master Jan 19, 2023
@bryantbiggs bryantbiggs deleted the fix/fifo-dlq-name branch January 19, 2023 22:19
antonbabenko pushed a commit that referenced this pull request Jan 19, 2023
@semantic-release-bot
chore(release): version 4.0.1 [skip ci]
7ded3fe 
### [4.0.1](v4.0.0...v4.0.1) (2023-01-19)

### Bug Fixes

* Correct `.fifo` postfix and KMS key ID usage on dead letter queue ([#51](#51)) ([2587a70](2587a70))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.1 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DLQ naming convention is wrong dlq_kms_master_key_id is not working
2 participants
@bryantbiggs @antonbabenko