fix: adding "no_age" param in simple bucket #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jjnunogarcia
changed the title
jjnunogarcia
force-pushed
the
missing-no-age-param
branch
2 times, most recently
from
f8baddf
to
d7e0fd3
Compare
jjnunogarcia
force-pushed
the
missing-no-age-param
branch
from
11ce527
to
ab00652
Compare
jjnunogarcia
changed the title
Added the missing `no_age` parameter to the terraform module. This parameter is now parsed and sent to the cloud-storage in GCP, ensuring proper configuration of the storage settings.
jjnunogarcia
force-pushed
the
missing-no-age-param
branch
from
ab00652
to
0af5e25
Compare
|
/gcbrun |
apeabody
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Thanks for the contribution @jjnunogarcia!
Confirmed no_age in TPG v5.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot configure lifecycle rules and add
no_ageparam because this line is missing.