-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds local_nvme_ssd_block_config to beta-public-cluster #1912
feat: adds local_nvme_ssd_block_config to beta-public-cluster #1912
Conversation
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…ules#1889) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ules#1877) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@gtsorbo , @ericyz , @Jberlinsky would you please take a look ? |
/gcbrun |
@apeabody, would you be able to trigger CI again and give your approval please ? |
/gcbrun (re-trigger, quota) |
had to rebase again, @gtsorbo , @ericyz , @Jberlinsky <ould you be able to approve please ? |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @florianMalbranque!
I've included a few notes below.
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Thanks for your review @apeabody, it should be good now |
/gcbrun |
Hi @florianMalbranque - Looks like we need a quick |
Woops 🤦 , @apeabody |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @florianMalbranque - A few final notes on the if beta_cluster
blocks as ephemeral_storage_config
is still beta.
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Thanks again for your reviews @apeabody ! it should be good now, PTAL |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @florianMalbranque!
…orm-google-modules#1912) Co-authored-by: Mateusz Jędrzejewski <33068017+matilote@users.noreply.github.com> Co-authored-by: Mateusz Jędrzejewski <mateusz.jedrzejewski@yahoo.pl> Co-authored-by: Amina Mansour <aminamansour@gmail.com>
No description provided.