renaming landing zone submodules to modules #694

Aayush-Abhyarthi · 2023-12-20T06:17:37Z

Description

https://github.ibm.com/GoldenEye/issues/issues/6952

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

Aayush-Abhyarthi · 2023-12-20T06:18:11Z

/run pipeline

ocofaigh · 2023-12-20T09:28:10Z

examples/landing_zone/README.md

@@ -1,6 +1,6 @@
 # Landing Zone example

-This example demonstrates how to use the management and workload VPC [modules](../../landing-zone-submodule/) to create a network VPC topology that is aligned with the network segregation key principles of the IBM Cloud [Framework for Financial Services](https://cloud.ibm.com/docs/framework-financial-services?topic=framework-financial-services-vpc-architecture-connectivity-overview).
+This example demonstrates how to use the management and workload VPC [modules](https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vsi/tree/main/modules/fscloud) to create a network VPC topology that is aligned with the network segregation key principles of the IBM Cloud [Framework for Financial Services](https://cloud.ibm.com/docs/framework-financial-services?topic=framework-financial-services-vpc-architecture-connectivity-overview).


that url is wrong

Aayush-Abhyarthi · 2023-12-20T15:10:01Z

/run pipeline

ocofaigh

see latest comments. Do you know if any of our modules or example are consuming these submodules directly? If so, lets ensure we update them to use new directory location.

I also notice that the submodule readme are missing a usage block. Can you add it please?

ocofaigh · 2023-12-20T16:28:21Z

examples/landing_zone/README.md

@@ -1,6 +1,6 @@
 # Landing Zone example

-This example demonstrates how to use the management and workload VPC [modules](../../landing-zone-submodule/) to create a network VPC topology that is aligned with the network segregation key principles of the IBM Cloud [Framework for Financial Services](https://cloud.ibm.com/docs/framework-financial-services?topic=framework-financial-services-vpc-architecture-connectivity-overview).
+This example demonstrates how to use the management and workload VPC [modules](../../modules/) to create a network VPC topology that is aligned with the network segregation key principles of the IBM Cloud [Framework for Financial Services](https://cloud.ibm.com/docs/framework-financial-services?topic=framework-financial-services-vpc-architecture-connectivity-overview).


../../modules/ won't render in hashicorp, needs to be full repo url

ocofaigh · 2023-12-20T16:29:59Z

README.md

@@ -38,7 +41,7 @@ This module creates the following IBM Cloud&reg; Virtual Private Cloud (VPC) net

 ### Presets

-In addition to this root module, this repository provides two submodules that call the root module with presets and defaults that are aligned with the general [Framework for Financial Services](https://cloud.ibm.com/docs/framework-financial-services?topic=framework-financial-services-vpc-architecture-about) management and workload VPC topologies. See the [landing-zone-submodules](/landing-zone-submodule/) for details.
+In addition to this root module, this repository provides two submodules that call the root module with presets and defaults that are aligned with the general [Framework for Financial Services](https://cloud.ibm.com/docs/framework-financial-services?topic=framework-financial-services-vpc-architecture-about) management and workload VPC topologies. See the [landing-zone-submodules](/modules/) for details.


suggest chaning to See the landing zone submodules in the [modules](https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/tree/main/modules) folder for details.

Aayush-Abhyarthi · 2024-01-21T09:58:01Z

/run pipeline

ocofaigh · 2024-01-22T17:53:48Z

modules/management-vpc/README.md

+### Usage
+```terraform
+module management_vpc {
+  source              = https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/tree/main/modules/management-vpc


thats not how you consume a submodule from github, it would be: "git::https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc.git//modules/management-vpc?ref=X.X.X"

However, lets use hashicorp as the source, which would be:

source = "terraform-ibm-modules/terraform-ibm-landing-zone-vpc/ibm//modules/management-vpc" version = "X.X.X" # replace X.X.X with a release version to lock into an exact release

ocofaigh · 2024-01-22T17:54:12Z

modules/workload-vpc/README.md

+### Usage
+```terraform
+module workload_vpc {
+  source              = https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/tree/main/modules/workload-vpc


same as https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone-vpc/pull/694/files#r1462213950

ocofaigh

see comments

Aayush-Abhyarthi · 2024-01-23T18:08:09Z

/run pipeline

ocofaigh · 2024-01-23T21:16:43Z

modules/management-vpc/README.md

+### Usage
+```terraform
+module management_vpc {
+  source              = "terraform-ibm-modules/terraform-ibm-landing-zone-vpc/ibm//modules/management-vpc"


sorry, source is still wrong here. should be terraform-ibm-modules/landing-zone-vpc/ibm//modules/management-vpc

ocofaigh · 2024-01-23T21:17:06Z

modules/workload-vpc/README.md

+### Usage
+```terraform
+module workload_vpc {
+  source              = "terraform-ibm-modules/terraform-ibm-landing-zone-vpc/ibm//modules/workload-vpc"


sorry, source is still wrong here. should be "terraform-ibm-modules/landing-zone-vpc/ibm//modules/workload-vpc"

Aayush-Abhyarthi · 2024-01-23T21:31:17Z

/run pipeline

terraform-ibm-modules-ops · 2024-01-25T09:52:11Z

🎉 This PR is included in version 7.16.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

renaming landing zone submodules to modules

d367b1d

ocofaigh reviewed Dec 20, 2023

View reviewed changes

Aayush-Abhyarthi added 2 commits December 20, 2023 20:37

fix: url

84b9df8

fix:url

8df3059

ocofaigh requested changes Dec 20, 2023

View reviewed changes

Aayush-Abhyarthi and others added 3 commits December 31, 2023 03:53

Merge branch 'main' into rename-to-modules

58a432d

Merge branch 'main' into rename-to-modules

01f66ea

resolve comments

8458631

ocofaigh reviewed Jan 22, 2024

View reviewed changes

ocofaigh requested changes Jan 22, 2024

View reviewed changes

fix: resolve comments

42340a1

ocofaigh reviewed Jan 23, 2024

View reviewed changes

resolve comments

bbf1b35

ocofaigh approved these changes Jan 25, 2024

View reviewed changes

ocofaigh merged commit f583bbb into main Jan 25, 2024
2 checks passed

ocofaigh deleted the rename-to-modules branch January 25, 2024 09:50

terraform-ibm-modules-ops added the released label Jan 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

renaming landing zone submodules to modules #694

renaming landing zone submodules to modules #694

Aayush-Abhyarthi commented Dec 20, 2023

Aayush-Abhyarthi commented Dec 20, 2023

ocofaigh Dec 20, 2023

Aayush-Abhyarthi commented Dec 20, 2023

ocofaigh left a comment

ocofaigh Dec 20, 2023

ocofaigh Dec 20, 2023

Aayush-Abhyarthi commented Jan 21, 2024

ocofaigh Jan 22, 2024 •

edited

Loading

ocofaigh Jan 22, 2024

ocofaigh left a comment

Aayush-Abhyarthi commented Jan 23, 2024

ocofaigh Jan 23, 2024

ocofaigh Jan 23, 2024

Aayush-Abhyarthi commented Jan 23, 2024

terraform-ibm-modules-ops commented Jan 25, 2024

renaming landing zone submodules to modules #694

renaming landing zone submodules to modules #694

Conversation

Aayush-Abhyarthi commented Dec 20, 2023

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

Aayush-Abhyarthi commented Dec 20, 2023

ocofaigh Dec 20, 2023

Choose a reason for hiding this comment

Aayush-Abhyarthi commented Dec 20, 2023

ocofaigh left a comment

Choose a reason for hiding this comment

ocofaigh Dec 20, 2023

Choose a reason for hiding this comment

ocofaigh Dec 20, 2023

Choose a reason for hiding this comment

Aayush-Abhyarthi commented Jan 21, 2024

ocofaigh Jan 22, 2024 • edited Loading

Choose a reason for hiding this comment

ocofaigh Jan 22, 2024

Choose a reason for hiding this comment

ocofaigh left a comment

Choose a reason for hiding this comment

Aayush-Abhyarthi commented Jan 23, 2024

ocofaigh Jan 23, 2024

Choose a reason for hiding this comment

ocofaigh Jan 23, 2024

Choose a reason for hiding this comment

Aayush-Abhyarthi commented Jan 23, 2024

terraform-ibm-modules-ops commented Jan 25, 2024

ocofaigh Jan 22, 2024 •

edited

Loading