Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NLB support #654

Merged
merged 9 commits into from
Apr 19, 2024
Merged

feat: add NLB support #654

merged 9 commits into from
Apr 19, 2024

Conversation

maheshwarishikha
Copy link
Member

@maheshwarishikha maheshwarishikha commented Apr 12, 2024

Description

Add NLB support

Issue: #8353

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

It adds the functionality to create Network Load Balancer(NLB). When the profile value in var.load_balancers is set as network-fixed, it signifies to setup a NLB. The existing subnet can be provided to provision NLB otherwise NLB resides at the first subnet from the subnets list. Subsequently, a listener, a pool, and pool members are connected to the NLB.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh removed their request for review April 15, 2024 08:47
@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

examples/complete/README.md Outdated Show resolved Hide resolved
@maheshwarishikha
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Member

@maheshwarishikha can you please provide more info on the release note?

Adds the functionality to create Network Load Balancer using module.

How does a consumer do this? What variable(s) do they need to use etc..

@maheshwarishikha
Copy link
Member Author

@maheshwarishikha can you please provide more info on the release note?

Adds the functionality to create Network Load Balancer using module.

How does a consumer do this? What variable(s) do they need to use etc..

done. thanks

@ocofaigh ocofaigh merged commit 0460e99 into main Apr 19, 2024
2 checks passed
@ocofaigh ocofaigh deleted the sm-8353 branch April 19, 2024 11:53
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants