d/aws_route53_zone: Filter on tags is containment, not exact equality

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11950.

Release note for CHANGELOG:

data-source/aws_route53_zone: Fixes regression from version 2.48.0 when filtering using `tags`

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsRoute53Zone_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsRoute53Zone_tags -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53Zone_tags
=== PAUSE TestAccDataSourceAwsRoute53Zone_tags
=== CONT  TestAccDataSourceAwsRoute53Zone_tags
--- PASS: TestAccDataSourceAwsRoute53Zone_tags (96.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	96.044s

[ewbankkit]

The updated test case without the corresponding fix gives:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsRoute53Zone_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsRoute53Zone_tags -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53Zone_tags
=== PAUSE TestAccDataSourceAwsRoute53Zone_tags
=== CONT  TestAccDataSourceAwsRoute53Zone_tags
--- FAIL: TestAccDataSourceAwsRoute53Zone_tags (78.85s)
    testing.go:640: Step 0 error: errors during apply:
        
        Error: no matching Route53Zone found
        
          on /tmp/tf-test064323633/main.tf line 22:
          (source code not available)
        
        
    testing.go:701: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.
        
        Error: errors during refresh: no matching Route53Zone found
        
        State: <nil>
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	78.928s
FAIL
GNUmakefile:24: recipe for target 'testacc' failed
make: *** [testacc] Error 1

[bflad]

I think this should be good to go once the merge conflicts are sorted. 👍

[ewbankkit]

Rebased to remove merge conflicts.
Re-ran acceptance test:

% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsRoute53Zone_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsRoute53Zone_tags -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53Zone_tags
=== PAUSE TestAccDataSourceAwsRoute53Zone_tags
=== CONT  TestAccDataSourceAwsRoute53Zone_tags
--- PASS: TestAccDataSourceAwsRoute53Zone_tags (120.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	122.219s

[bflad]

Looks great, thanks for this fix (and nice enhancement to keyvaluetags to help other resources with this problem in the future), @ewbankkit 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsRoute53Zone_name (53.44s)
--- PASS: TestAccDataSourceAwsRoute53Zone_id (53.47s)
--- PASS: TestAccDataSourceAwsRoute53Zone_vpc (92.55s)
--- PASS: TestAccDataSourceAwsRoute53Zone_tags (93.48s)
--- PASS: TestAccDataSourceAwsRoute53Zone_serviceDiscovery (102.37s)

[ghost]

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!