Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ForceNew for resource_arm_function_app for the app_service_plan_id #4439

Merged
merged 2 commits into from
Sep 30, 2019

Conversation

MarkDordoy
Copy link
Contributor

A function app should not have to be re-created when you re-associate it to another service plan. This PR will bring the resource_arm_function_app in line with its closely related resource_arm_app_service resource

@ghost ghost added the size/XS label Sep 26, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @MarkDordoy

Thanks for this PR - if we can update the documentation then this otherwise LGTM 👍

azurerm/resource_arm_function_app.go Show resolved Hide resolved
@ghost ghost added the documentation label Sep 30, 2019
@tombuildsstuff tombuildsstuff merged commit 3f572c3 into hashicorp:master Sep 30, 2019
tombuildsstuff added a commit that referenced this pull request Sep 30, 2019
@ghost
Copy link

ghost commented Oct 4, 2019

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants