Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for configuring external_entropy_access on secrets engines #792

Merged
merged 4 commits into from
Jun 12, 2020

Conversation

austingebauer
Copy link
Member

@austingebauer austingebauer commented Jun 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #765

This PR adds support for configuring external_entropy_access on secrets engines via the /sys/mounts/:path API.

I had to bring both the vault/api and vault/sdk versions up to hashicorp/vault@47a54ac to enable this. See circleci pipeline with larger set of tests ran on this change.

Release note for CHANGELOG:

* For the `/sys/mounts/{path}` endpoint, adds support for `external_entropy_access` ([#792](https://github.com/terraform-providers/terraform-provider-vault/pull/792)).

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestResourceMount'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestResourceMount -timeout 120m
?       github.com/terraform-providers/terraform-provider-vault [no test files]
?       github.com/terraform-providers/terraform-provider-vault/cmd/coverage    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/util    (cached) [no tests to run]
=== RUN   TestResourceMount
--- PASS: TestResourceMount (0.19s)
=== RUN   TestResourceMount_Local
--- PASS: TestResourceMount_Local (0.17s)
=== RUN   TestResourceMount_SealWrap
--- PASS: TestResourceMount_SealWrap (0.17s)
=== RUN   TestResourceMount_KVV2
--- PASS: TestResourceMount_KVV2 (0.15s)
=== RUN   TestResourceMount_ExternalEntropyAccess
--- PASS: TestResourceMount_ExternalEntropyAccess (0.23s)
PASS
ok      github.com/terraform-providers/terraform-provider-vault/vault   (cached)
...

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit on the schema entry and small request to update the test. Assuming no issues there then 👍

vault/resource_mount.go Outdated Show resolved Hide resolved
vault/resource_mount_test.go Show resolved Hide resolved
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@austingebauer austingebauer merged commit 0118a19 into master Jun 12, 2020
@austingebauer austingebauer deleted the add-external-entropy-access branch June 12, 2020 21:31
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No option to enable external_entropy_access on secrets engine
2 participants