Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAsar Canary broken on tauOS/Silverblue #61

Closed
lleyton opened this issue Dec 6, 2022 · 4 comments · Fixed by #133
Closed

OpenAsar Canary broken on tauOS/Silverblue #61

lleyton opened this issue Dec 6, 2022 · 4 comments · Fixed by #133
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lleyton
Copy link
Member

lleyton commented Dec 6, 2022

Describe the bug
openasar-canary doesn't install properly when using an rpm-ostree based distribution like tauOS

To Reproduce
Steps to reproduce the behavior:

  1. Install openasar-canary
  2. Open Discord Canary

Expected behavior
OpenAsar should be loaded

Affected (please complete the following information):

  • Distro tauOS, Fedora Silverblue
  • Package openasar-canary

Additional context
Currently, we install openasar-canary using a trigger scriptlet. These are not currently supported by rpm-ostree. We'll need to figure out a way around this.

@lleyton lleyton added the bug Something isn't working label Dec 6, 2022
@getchoo
Copy link
Contributor

getchoo commented Dec 8, 2022

maybe we could just make a second or split package that replaces app.asar during %install. this would also solve a possible issue i've noticed in the current package, which is that when openasar-canary is removed, the modified app.asar is not due to the lack of a %postun. it could also make the package easier to install imo, since currently you need to install openasar-canary and then discord-canary, which isn't super intuitive and not apparent unless reading the spec file

@lleyton
Copy link
Member Author

lleyton commented Dec 10, 2022

I'm a bit confused, would this package bundle discord-canary but with the modified app.asar?

@getchoo
Copy link
Contributor

getchoo commented Dec 10, 2022

no, it could be a subpackage or completely separate package (on second thought the later would probably be easiest) named something like discord-canary-openasar that would bundle the modified asar. the discord-canary package would remain the same

@lleyton
Copy link
Member Author

lleyton commented Dec 11, 2022

ahh, gotcha, I think something like discord-canary-openasar like how you said would work. I'll have this issue up for grabs then :P

@lleyton lleyton added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 11, 2022
@madonuko madonuko mentioned this issue Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants