-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review canopy cover extractor & output #186
Comments
The following RGB full-field image (05/29) was run through the extractor: The datapoints were created in per-plot streams. You can find a datapoint by:
There is currently one canopy cover entry for all the plots we have coverage of in full field mosaic. We will need to check the number, in the linked example the datapoint properties include source image and value:
Here, Range 25 Column 14 is reported as having 46.2% green pixel coverage on this date. To check this, I loaded the _thumb.tif image from that dataset in QGIS and created a plot.js file with the GeoJSON from the sensors link: |
Looks good so far. Does this issue cover insertion into BETYdb? |
@dlebauer yes, this should've pushed 864 traits to BETYdb. I put a link to the variable in the metadata: ...but I can't remember the right query to see the actual trait observations. They should be in there though, added today. |
I've purged data from BETYdb: delete from traits where variable_id = (select id from variables where name = 'canopy_cover') |
@max-zilla Shall we modify these to avoid confusion? |
@ZongyangLi good idea, that was old name before I understood. will rename to CanopyCoverPercentage. |
Content pasted from terraref/reference-data#186 (comment)
@ZongyangLi I moved the quality statement to the README terraref/extractors-stereo-rgb#17 - please flush it out there. Thanks! |
We have just developed an algorithm to enhance illumination condition of RGB images. The paper is in review right now. We can test on these datasets to address soil issues under shadow. I tagged Patrick on this issue. We will update soon. |
Wasit - this extractor is ready to go, had been tested, checked etc. Please create a new pull request or issue describing this feature and we can put it in the pipeline for the next release. |
@dlebauer Yes, we can put it in the next release. As a reference, here is a preliminary result of the algorithm using the image shown above. Left: Original image ---- Right: Enhanced image |
@ZongyangLi can you please review the output data? If you are logged in to BETYdb at https://terraref.ncsa.illinois.edu/bety you can download it from https://terraref.ncsa.illinois.edu/bety/search.csv?search=canopy+cover&include_unchecked=true |
needed to update output from fraction in range [0,1] to percent [0,100] #234 |
No longer relevant owing to new implementation. But I have marked all data generated by the old version of the extractor as 'checked=-1' i.e. 'checked and found to be in error' because it is clear that the algorithm got confused: update traits set checked = -1
where method_id in
(select id from methods where name = 'Canopy Cover Estimation from Field Scanner RGB images')
and site_id in
(select id from sites where sitename not like '%Season 6%');
-- UPDATE 82341 |
Review issue for the canopy cover extractor and output using RGB full field input.
Completion criteria:
The text was updated successfully, but these errors were encountered: