Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly filter for ENABLE_LOADING and DISABLE_LOADING #854

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Explicitly filter for ENABLE_LOADING and DISABLE_LOADING #854

merged 2 commits into from
Dec 1, 2021

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Dec 1, 2021 •
edited

Description

This prevents custom actions ending on _LOADING from being filtered.

Please review @terrestris/devs.

Related issues or pull requests

--

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I have added a screenshot/screencast to illustrate the visual output of my update.
  • I have added the proposed change to the CHANGELOG.md.
  • I have run the test suite successfully (run npm test locally).

@dnlkoch dnlkoch merged commit 1503f56 into master Dec 1, 2021
@dnlkoch dnlkoch deleted the fix-action-filter branch December 1, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weskamm weskamm weskamm approved these changes

@KaiVolland KaiVolland KaiVolland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnlkoch @weskamm @KaiVolland