Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t2 run/push: stub gunzip & extract in remote binary request tests. Fixes gh-711 #712

Merged
merged 1 commit into from
Apr 27, 2016

Conversation

rwaldron
Copy link
Contributor

Signed-off-by: Rick Waldron waldron.rick@gmail.com

@rwaldron
Copy link
Contributor Author

Ok, now it's dying in provision.js

@rwaldron
Copy link
Contributor Author

First run report (to save readers from having to wade through the travis logs):

@rwaldron
Copy link
Contributor Author

@johnnyman727
Copy link
Contributor

Looks good - what instigated this PR?

@wyze
Copy link
Member

wyze commented Apr 27, 2016

My report about tests not completing on Node 5.x. Which @mattsoftware was running into on Slack. Seems there are a few issues open with tests just not completing all the way. Then when that happens Travis still reports it passed, because all the tests did pass, but not all were ran. Hopefully this can put a stop to all of that.

It was very good this was able to be reproduced locally, as it can be iterated on much faster than pushing and waiting for Travis.

@rwaldron
Copy link
Contributor Author

It was very good this was able to be reproduced locally, as it can be iterated on much faster than pushing and waiting for Travis.

Sanity saver :)

@rwaldron rwaldron merged commit bc23cca into tessel:master Apr 27, 2016
@mattsoftware
Copy link
Contributor

My tests still seem to die even if I merge this patch into my repo. This time in/after controller.js

Same point if I run node v5.0.0 or v5.11.0

If you need me to provide any debugging etc let me know!

@wyze
Copy link
Member

wyze commented Apr 28, 2016

Whats your output if you run grunt -v?

@rwaldron
Copy link
Contributor Author

This was only one part of a set of fixes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants