Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<MockBackend as Backend>::Error should be a real error type #48

Open
a1phyr opened this issue May 22, 2023 · 4 comments
Open

<MockBackend as Backend>::Error should be a real error type #48

a1phyr opened this issue May 22, 2023 · 4 comments

Comments

@a1phyr
Copy link
Contributor

a1phyr commented May 22, 2023

Currently, <MockBackend as Backend>::Error is () so it cannot be converted to Box<dyn std::error::Error>.

Using std::convert::Infallible or a standalone type that implement std::error::Error would be more convenient.

@tesselode
Copy link
Owner

Indeed. I came across this issue when trying to get the doc tests passing when the cpal feature isn't enabled. I ultimately didn't bother fixing it because there were other issues I would have to fix too, and it wasn't worth it. Are you finding this to be an issue outside of running tests?

@a1phyr
Copy link
Contributor Author

a1phyr commented May 29, 2023

I came across this issue in the exact same situation. I added "cpal" feature in my dev-dependencies and it worked.
It may still be worth fixing, though.

@tesselode
Copy link
Owner

Are you making a library based on Kira?

@a1phyr
Copy link
Contributor Author

a1phyr commented Aug 10, 2023

Yes I was making asset_manager-kira, an integration with assets_manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants