Fixes busser install for older omnibus windows installs #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this with chef 11.18.6 and validated that the verifier runs without error. |
|
+1 |
1 similar comment
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes test-kitchen/busser#25
Older (chef 11) omnibus installs on Windows do not propogate the the changes to the path so commands made in the same kitchen run will not have the chef embedded bin on the path. This is exacerbated by older versions of rubygems like the one that ships with chef 11 where the binstubs do not include an absolute path to the ruby interpreter. As a result he busser installer cannot find ruby.exe.
This was fixed for the provisioners in this commit, but alas, the busser still breaks.
This pr centralizes the
reload_ps1_pathmethod and uses it in the busser installer.