Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use winrm v2 release gems #1061

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Use winrm v2 release gems #1061

merged 1 commit into from
Sep 2, 2016

Conversation

mwrock
Copy link
Member

@mwrock mwrock commented Jun 20, 2016

This is a work in progress and should not be merged until winrm v2 and corresponding releases in winrm-fs and winrm-elevated are released.

This is mostly working but the following needs to happen:

  • tighten up error output in winrm (its a bit much)
  • convert winrm-elevated and its usage to work with v2
  • get the tests passing

@mwrock mwrock mentioned this pull request Jun 20, 2016
@mwrock
Copy link
Member Author

mwrock commented Jul 1, 2016

Errors are looking good now. Working to get elevated transport functional.

@mwrock
Copy link
Member Author

mwrock commented Jul 1, 2016

see WinRb/winrm-elevated#11

@mwrock
Copy link
Member Author

mwrock commented Jul 2, 2016

Might be changing the shell interface for winrm-elevated

@mwrock
Copy link
Member Author

mwrock commented Jul 4, 2016

Build break is now filezilla related and I'll address in a separate pr.

@mwrock mwrock changed the title WIP: use winrm v2 Use winrm v2 release gems Aug 31, 2016
@mwrock
Copy link
Member Author

mwrock commented Aug 31, 2016

This is no longer a work in progress. There are a couple post release items to be done here. Currently the Gemfile pins kitchen-inspec and train to their respective winrm-v2 branches. This breaks the kitchen-init cucumber feature. For now I have commented out that test and after kitchen-inspec and train release we can revert the comments in the kitchen-init test and remove the pins in the gemfile.

@mwrock
Copy link
Member Author

mwrock commented Aug 31, 2016

If you want to test, this should work with any windows based cookbook. Additionally, kitchen-dsc based projects can also now converge on Windows Nano Server. If you clone https://github.com/mwrock/DSCTextfile and:

bundle install
bundle exec kitchen verify

that should create my WindowsNanoDCS vagrant box and converge/test the resource.

@mwrock
Copy link
Member Author

mwrock commented Sep 1, 2016

I should mention here that we have been using this branch in the chef and chef-dk acceptance tests that test every package that drops into the current channel for the past couple months.

@cheeseplus
Copy link

cheeseplus commented Sep 2, 2016

+ a billion

@smurawski
Copy link
Contributor

👍

@smurawski smurawski merged commit 1f71b4b into master Sep 2, 2016
@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
@tas50 tas50 deleted the winrm-v2 branch June 28, 2018 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants