Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: HTTP wait strategy #715

Closed
HofmeisterAn opened this issue Dec 19, 2022 · 0 comments
Closed

[Enhancement]: HTTP wait strategy #715

HofmeisterAn opened this issue Dec 19, 2022 · 0 comments
Assignees
@HofmeisterAn
Labels
enhancement New feature or request

Comments

@HofmeisterAn
Copy link
Collaborator

HofmeisterAn commented Dec 19, 2022 •
edited

Problem

Testcontainers for .NET does not offer a wait strategy for HTTP requests. Other language implementations like Java and Go have a wait strategy specifically for HTTP requests.

Solution

Add a wait strategy for HTTP requests that aligns with the other language implementations.

Benefit

Using an HTTP wait strategy is a common use case. Developers do not have to implement it themselves.

Alternatives

There are two open PRs without response after the review:

Would you like to help contributing this enhancement?

Yes
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Dec 19, 2022
@HofmeisterAn HofmeisterAn self-assigned this Dec 19, 2022
HofmeisterAn added a commit that referenced this issue Dec 20, 2022
@HofmeisterAn
feat(#715): Prepare HTTP wait strategy
1922cc1
HofmeisterAn added a commit that referenced this issue Dec 20, 2022
@HofmeisterAn
feat(#715): Add HttpWaitStrategy
6c264f1
HofmeisterAn added a commit that referenced this issue Dec 20, 2022
@HofmeisterAn
feat(#715): Add HttpWaitStrategy tests
09332e7
HofmeisterAn added a commit that referenced this issue Dec 21, 2022
@HofmeisterAn @sumihiran @kiview
feat(#715): Add HttpWaitStrategy (#717)
67bdd1d 
Co-authored-by: Nuwan Sumihiran <sumihiran.nuwan@gmail.com>
Co-authored-by: Alfred Neequaye <aneequaye@acsint.io>
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HofmeisterAn HofmeisterAn

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HofmeisterAn