Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#715): Add HttpWaitStrategy #717

Merged
merged 8 commits into from
Dec 21, 2022
Merged

feat(#715): Add HttpWaitStrategy #717

merged 8 commits into from
Dec 21, 2022

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

Adds the HttpWaitStrategy implementation to wait for an HTTP(S) endpoint to return a particular status code.

Why is it important?

Other Testcontainers implementations support an HTTP wait strategy. This PR increases the alignment with other languages incl. the development experience.

Related issues

Follow-ups

  • Allow untrusted SSL certificates.
  • Support basic HTTP authentication.

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Dec 20, 2022
@netlify
Copy link

netlify bot commented Dec 20, 2022 •
edited

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 67e33b9
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63a2dee2a414a00008c9f4a8
😎 Deploy Preview https://deploy-preview-717--testcontainers-dotnet.netlify.app/api/wait_strategies
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kiview
kiview previously approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added some suggestions to explain the default port behavior more explicitly.

docs/api/wait_strategies.md Outdated Show resolved Hide resolved
docs/api/wait_strategies.md Outdated Show resolved Hide resolved
src/Testcontainers/Configurations/WaitStrategies/HttpWaitStrategy.cs Show resolved Hide resolved
@HofmeisterAn @kiview
Update docs/api/wait_strategies.md
b8ae06a 
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@HofmeisterAn @kiview
Update docs/api/wait_strategies.md
67e33b9 
Co-authored-by: Kevin Wittek <kiview@users.noreply.github.com>
@HofmeisterAn HofmeisterAn merged commit 67bdd1d into develop Dec 21, 2022
@HofmeisterAn HofmeisterAn deleted the feature/715-add-http-wait-strategy branch December 21, 2022 10:41
@HofmeisterAn HofmeisterAn changed the title Feature/715 add http wait strategy feat(#715): Add HttpWaitStrategy (#717) Dec 21, 2022
@HofmeisterAn HofmeisterAn changed the title feat(#715): Add HttpWaitStrategy (#717) feat(#715): Add HttpWaitStrategy Dec 21, 2022
This was referenced Dec 21, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HofmeisterAn @kiview