chore: improve error wrapping in some docker container methods and compose module #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stevenh
force-pushed
the
chore/improve-error-wrapping
branch
from
69bea22
to
d8ae013
Compare
mdelapenya
reviewed
Aug 14, 2024
options_test.go
Outdated
| @@ -97,7 +97,7 @@ func TestWithLogConsumers(t *testing.T) { | |||
| // we expect an error because the MySQL environment variables are not set | |||
| // but this is expected because we just want to test the log consumer | |||
| require.Error(t, err) | |||
| require.Contains(t, err.Error(), "container exited with code 1") | |||
| require.Contains(t, err.Error(), "start container: container exited with code 1") | |||
There was a problem hiding this comment.
Suggested change
| require.Contains(t, err.Error(), "start container: container exited with code 1") | |
| require.Contains(t, err.Error(), "start container: started hook: wait until ready: container exited with code 1") |
There was a problem hiding this comment.
This is using Contains so it only has to check for base error we're expecting. This specifically avoids checking any wrapping that might happen as that may change making the test fragile, it's essentially as close to errors.Is as we can get.
Improve error wrapping to help detect failures in compose and wait tests.
stevenh
force-pushed
the
chore/improve-error-wrapping
branch
from
ed06f7c
to
cd3cb56
Compare
mdelapenya
changed the title
mdelapenya
added a commit
that referenced
this pull request
Aug 16, 2024
* main: fix: config via environment (#2725) fix(redpanda): race condition on port check (#2692) fix: logging restart (#2697) fix!: docker authentication setup (#2727) chore: improve error wrapping (#2720) chore: run make tests in verbose mode (#2734) chore(deps): bump github.com/docker/docker from 27.1.0+incompatible to 27.1.1+incompatible (#2733) fix(kafka): port race on start (#2696) docs: fix broken doc tags (#2732) fix: nginx request failures (#2723) fix(compose): container locking (#2722) fix(wait): log test timeout (#2716) chore: increase timeout values (#2719) chore: remove unused parameters (#2721) chore(mockserver): silence warning about internal port (#2730) feat(wait): skip internal host port check (#2691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error wrapping to help detect failures in compose and wait tests.