Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused parameters #2721

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Aug 8, 2024

Remove unused parameters from private functions.

Remove unused parameters from private functions.
@stevenh stevenh requested a review from a team as a code owner August 8, 2024 19:05
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 6bdfc04
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66b517109ee44b00086098b4
😎 Deploy Preview https://deploy-preview-2721--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

IIRC I started with functions with the same signature, but it probably does not matter at all

@mdelapenya mdelapenya self-assigned this Aug 12, 2024
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Aug 12, 2024
@mdelapenya mdelapenya merged commit 3bc7217 into testcontainers:main Aug 12, 2024
112 checks passed
mdelapenya added a commit that referenced this pull request Aug 16, 2024
* main:
  fix: config via environment (#2725)
  fix(redpanda): race condition on port check (#2692)
  fix: logging restart (#2697)
  fix!: docker authentication setup (#2727)
  chore: improve error wrapping (#2720)
  chore: run make tests in verbose mode (#2734)
  chore(deps): bump github.com/docker/docker from 27.1.0+incompatible to 27.1.1+incompatible (#2733)
  fix(kafka): port race on start (#2696)
  docs: fix broken doc tags (#2732)
  fix: nginx request failures (#2723)
  fix(compose): container locking (#2722)
  fix(wait): log test timeout (#2716)
  chore: increase timeout values (#2719)
  chore: remove unused parameters (#2721)
  chore(mockserver): silence warning about internal port (#2730)
  feat(wait): skip internal host port check (#2691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants