Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass queryString to the JdbcDatabaseDelegate #741

Merged
merged 6 commits into from
Jul 10, 2018
Merged

Pass queryString to the JdbcDatabaseDelegate #741

merged 6 commits into from
Jul 10, 2018

Conversation

dmart28
Copy link
Contributor

@dmart28 dmart28 commented Jun 9, 2018

Fix for the #727 issue.

@rnorth
Copy link
Member

rnorth commented Jun 10, 2018

Potentially overtaken by another PR - reassess after merging #617.

# Conflicts:
#	modules/jdbc-test/src/test/java/org/testcontainers/jdbc/JDBCDriverTest.java
#	modules/jdbc/src/main/java/org/testcontainers/jdbc/ContainerDatabaseDriver.java
@kiview
Copy link
Member

kiview commented Jun 22, 2018

@rnorth Just wanted to ping you, since #617 has been merged now. PR LGTM.

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the contribution @dmart28, and sorry it's taken ages to merge.

@rnorth rnorth merged commit 5b4d0ee into testcontainers:master Jul 10, 2018
@rnorth
Copy link
Member

rnorth commented Jul 12, 2018

Released in 1.8.1! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants