Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.7.4 Test Failure #5

Closed
kevin-j-m opened this issue Sep 28, 2021 · 1 comment
Closed

Ruby 2.7.4 Test Failure #5

kevin-j-m opened this issue Sep 28, 2021 · 1 comment

Comments

@kevin-j-m
Copy link
Contributor

kevin-j-m commented Sep 28, 2021

The gemspec mentions 2.7 as the minimum ruby version; however, running the test suite does not appear to pass (at least for me, locally) when using 2.7.4.

Reproduction Steps

  1. Set ruby version to 2.7.4
  2. Run tests (I did so with rake)

Expected

Tests Pass

Actual

  1) Error:
VerifyTest#test_uses_a_captor_for_a_complex_arg:
ArgumentError: ArgumentError
    /mocktail/lib/mocktail/handles_dry_call/validates_arguments.rb:41:in `validate'
    /mocktail/lib/mocktail/handles_dry_call.rb:14:in `handle'
    /mocktail/lib/mocktail/imitates_type/makes_double/declares_dry_class.rb:42:in `block (2 levels) in define_double_methods!'
    /mocktail/test/safe/verify_test.rb:135:in `test_uses_a_captor_for_a_complex_arg'

61 runs, 295 assertions, 0 failures, 1 errors, 0 skips

Notes

I also ran the tests locally with ruby 3.0.1, and tests passed for me then.

@al2o3cr
Copy link
Contributor

al2o3cr commented Oct 10, 2021

0.0.2 bumped the minimum version to 3.0:

spec.required_ruby_version = Gem::Requirement.new(">= 3.0.0")

@searls searls closed this as completed Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants