Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Justification for building a custom Docker image instead of using the canonical Ruby one #57

Closed
seeflanigan opened this issue Sep 2, 2016 · 0 comments

Comments

@seeflanigan
Copy link
Contributor

seeflanigan commented Sep 2, 2016

Per docs for the canonical Ruby image. "The onbuild tag expects a Gemfile.lock in your app directory."

Because Gemfile.lock is presently not versioned, building an image for suture based on the Ruby image results in the following fatal error:

Status: Downloaded newer image for ruby:2.1-onbuild
# Executing 4 build triggers...
Step 1 : COPY Gemfile /usr/src/app/
Step 1 : COPY Gemfile.lock /usr/src/app/
lstat Gemfile.lock: no such file or directory

There are workarounds, building a custom image instead of the conventional one. However, by following the idiomatic approach of using the official Ruby image, we defer some liability for incidental complexity to the official image maintainers.

However according to this it is recommended not to version Gemfile.lock for library development.

Therefore, I will leave this note as a reminder to myself and future maintainers as to the justification for building a custom image in favor of using the onbuild tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant