fix(ByRole): Ensure valid query selectors in all transpilation targets #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bc9e015:
|
eps1lon
force-pushed
the
fix/valid-selector
branch
from
6d458ce
to
4e1da7a
Compare
eps1lon
force-pushed
the
fix/valid-selector
branch
from
4e1da7a
to
5f464b3
Compare
Codecov Report
@@ Coverage Diff @@
## main #1055 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 927 928 +1
Branches 288 287 -1
=========================================
+ Hits 927 928 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ph-fritsche
approved these changes
Oct 14, 2021
|
🎉 This PR is included in version 8.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
MatthiasKainer
pushed a commit
to MatthiasKainer/dom-testing-library
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes erros like "'*[role~="textbox"],[object Set]' is not a valid selector" when using
moduleentrypoints.Why:
I only reviewed the transpiled node code in #1046 which didn't transpile
...away. Themoduleentrypoint does though.Example failure: https://app.circleci.com/pipelines/github/mui-org/material-ui/53629/workflows/6c71e957-ee1c-4e20-8ea4-cd856f7e27d8/jobs/305270
Bad transpilation:
return [explicitRoleSelector].concat(implicitRoleSelectors != null ? implicitRoleSelectors : []).join(',');-- https://unpkg.com/@testing-library/dom@8.9.0/dist/@testing-library/dom.esm.js
This is equiavalent to
['[role="button"]'].concat(new Set(['button']))which evaluates to['[role="button"]', new Set(['button'])]instead of the intended['[role="button"]', 'button']The
moduleentrypoint targets old browsers without support for spread syntax. We assume that every...target is an array which means...can be transpiled usingArray.prototype.concat. However, this breaks for any other iterable (here:Set). In other words, we're transpiling with@babel/plugin-transform-spreadenablingloosemode (https://babeljs.io/docs/en/babel-plugin-transform-spread#loose).How:
Directly use
concatand leave a comment about using...Checklist:
[ ]Documentation added to thedocs site
moduleentrypoint, pasted into local fork of mui-org/material-ui and run successfullyyarn test:karmawhich was failing without this change)[ ]TypeScript definitions updated