Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider <output /> labelable #968

Merged
merged 1 commit into from
Jun 3, 2021
Merged

fix: Consider <output /> labelable #968

merged 1 commit into from
Jun 3, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 3, 2021

What:

Closes #866

Why:

<output /> is labelable

How:

Bump dom-accessibility-api to include eps1lon/dom-accessibility-api#666

Checklist:

@eps1lon eps1lon added the bug Something isn't working label Jun 3, 2021
@eps1lon eps1lon changed the title fix: Consider output labelable fix: Consider <output /> labelable Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #968 (2e52fdb) into main (86fb094) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #968   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          966       966           
  Branches       298       298           
=========================================
  Hits           966       966           
Flag Coverage Δ
node-10.14.2 100.00% <ø> (ø)
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-15 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fb094...2e52fdb. Read the comment docs.

@eps1lon eps1lon merged commit 56a4c75 into main Jun 3, 2021
@eps1lon eps1lon deleted the eps1lon-patch-1 branch June 3, 2021 09:27
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

🎉 This PR is included in version 7.31.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

eps1lon added a commit to eps1lon/dom-testing-library that referenced this pull request Jun 3, 2021
@github-actions
Copy link

🎉 This PR is included in version 8.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getByRole with name not working properly for output element
1 participant