Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use syntax compatible with older TypeScript versions #1026

Merged
merged 5 commits into from
Sep 11, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 10, 2021

What:

Closes #1025

Why:

#1016 introduce syntax that's not compatible with older TypeScript versions.

How:

Don't label tuple members.

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 10, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 304e312:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #1026 (304e312) into main (74c63b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1026   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          916       916           
  Branches       286       286           
=========================================
  Hits           916       916           
Flag Coverage Δ
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-16.9.1 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c63b7...304e312. Read the comment docs.

@eps1lon
Copy link
Member Author

eps1lon commented Sep 10, 2021

Merging since the node 16 failure is due to nodejs/node#40030

@eps1lon
Copy link
Member Author

eps1lon commented Sep 10, 2021

Merging since the node 16 failure is due to nodejs/node#40030

Nevermind. Release is blocked by any failing node version so we'll have to wait for a new node release anyway.

timdeschryver
timdeschryver previously approved these changes Sep 10, 2021
@eps1lon eps1lon merged commit 8311c8d into testing-library:main Sep 11, 2021
@eps1lon eps1lon deleted the fix/type-syntax branch September 11, 2021 08:57
@github-actions
Copy link

🎉 This PR is included in version 8.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error from query-helpers.d.ts
2 participants