Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to puppeteer 2.x.x #22

Merged
merged 1 commit into from
Mar 10, 2020
Merged

feat: upgrade to puppeteer 2.x.x #22

merged 1 commit into from
Mar 10, 2020

Conversation

abraham
Copy link
Contributor

@abraham abraham commented Mar 10, 2020

Fixes peerDependencies warning.

npm WARN pptr-testing-library@0.4.0 requires a peer of puppeteer@^1.5.0 but none is installed. You must install peer dependencies yourself.

@patrickhulce
Copy link
Collaborator

thanks @abraham! WDYT about using || to allow either 1.x or 2.x rather than force everyone onto 2.x?

@abraham
Copy link
Contributor Author

abraham commented Mar 10, 2020

@patrickhulce I'd keep the peerDependencies as just 2.x since the tests are only running against 2.x. People can still use 1.x if they want with a warning.

@patrickhulce
Copy link
Collaborator

People can still use 1.x if they want with a warning.

I could say the same to you for 2.x and close this ;)

We're already running a test matrix against old versions of puppeteer in travis. Why not just add 1.19 + 2.0 to it and be more flexible with peer dependencies?

@abraham
Copy link
Contributor Author

abraham commented Mar 10, 2020

I've updated it to "^1.5.0 || ^2.0.0"

@patrickhulce patrickhulce merged commit bd84bbb into testing-library:master Mar 10, 2020
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much @abraham!

@abraham abraham deleted the pptr-v2 branch March 10, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants