fix(tests and events): resolves unsupported events and passing tests #57
Conversation
| @@ -169,9 +172,9 @@ test('onInput works', () => { | |||
| test('calling `fireEvent` directly works too', () => { | |||
There was a problem hiding this comment.
Let's add a test specifically for the issue tagged here or is that one not intended to be solved by this?
There was a problem hiding this comment.
I added those to the big list of tests, they should be covered, they were just missing before. With this bug they would have passing tests anyway.
There was a problem hiding this comment.
The other related issue, I think the bottom issue in open was about events that were already covered in this test suite too. All passed.
There was a problem hiding this comment.
updated the description to link to the issue as that was missing
There was a problem hiding this comment.
Would it be worth adding reverse tests? I dont know if if thats a thing but we could write tests that check 'onpointerenter' in dom and once they fail, we'd know we could delete these patches?
There was a problem hiding this comment.
I would leave them out for now
There was a problem hiding this comment.
Worth adding them in another pr? Like I said, looking for ways to contribute
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
typo Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
|
Thanks for the support @JoviDeCroock |
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
No worries should be published now @mikerob215 will focus on #50 now |
fixes #51
fixes #23
I updated the test suite to use names for event handlers in camel case like users do( ie:
onClickwas being tested asonclick). Once this is corrected,a number of tests will fail as JSDOM doesnt have support for them. When a user writea a component with a prop like
onPointerEnter, preact will do something like'on' + eventName.toLowerCase() in elemand in jsdom that wont work. It leads to preact creating an event handler calledPointerEnterrather thanpointerEnter.To solve I've overridden
fireEventsimilar to how its done in RTL, the difference is that we make the same check as preact,eventName.toLowerCase() in dom, to determine what the dispatch event's name should be.Currently the PTL library typings indicate that this is supported and it also works fine in RTL.
First I fixed a test case then spent some time in a bugger to figure who was renaming the event names
Checklist: