-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for pageup and pagedown control keys #734
feat: add support for pageup and pagedown control keys #734
Conversation
Thanks for contributing to this library❤️ If I recall correctly, |
On long text content in I tested this on a Mac using |
Just tested it again using a |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad3fb81:
|
Codecov Report
@@ Coverage Diff @@
## main #734 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 50 50
Lines 958 965 +7
Branches 385 389 +4
=========================================
+ Hits 958 965 +7
Continue to review full report at Codecov.
|
I think the cursor movement won't be exactly the same on different platforms in a real browser environment either. Maybe we should not encourage assuming the cursor position after one of these keys is used. The added entries in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JohannesFischer Could you split up the behaviorPlugin
? Keeping the changes for input
and keyDef
but removing PageUp
/PageDown
from textarea
and contenteditable
?
How to handle the cursor movement for the latter needs more discussion while the other parts are ready to be merged.
@ph-fritsche Done. Split up the behavior for the textarea and editable content in |
@all-contributors add @JohannesFischer code |
I've put up a pull request to add @JohannesFischer! 🎉 |
🎉 This PR is included in version 13.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks for the credit @ph-fritsche |
What:
Adding support for
PageUp
andPageDown
control block keys as requested in issue #694Why:
To support more possible user inputs.
How:
Add
PageDown
andPageUp
to keymap. The behavior equals the ofHome
andEnd
keys.Checklist:
Keys need to be added to special characters when this gets merged.